search

romanoh / Mp3tag

Mp3tag tools
58 stars 9 forks source link

[VGMdb] Album image previews are broken #5

Closed TheShadowRunner closed 3 years ago

TheShadowRunner commented 3 years ago

As VGMdbAlbumParser.inc expects .jpg or .png images but VGMdb recently switched to .webp. Hoping a fix is possible. Thanks for your dedication in keeping these scripts going !

romanoh commented 3 years ago

Hello

the VGMdb is working for me, the Json and normal version, can you give an album example? also the file extension does not matter as the parser gets the full link.

imagem

TheShadowRunner commented 3 years ago

Here's an exemple : https://vgmdb.net/album/107313

More info directly from the horse's mouth: "album cover filetype is determined by whatever type the original image was", meaning if the format uploaded was jpg, it'll remain jpg [and work with the script]. But if a user uploads a webp, vgmdb will use it as-is (= my exemple), in this case it breaks the script. So they didn't switch to webp completely but rather added support for it, I was mistaken.

Thanks for your support.

romanoh commented 3 years ago

You are right. i first must see if mp3tag suports webp. edit: it does not only : imagem

i see what can i do

Edit: The ID3 standard recommends png and jpg for best compatibility.

romanoh commented 3 years ago

I cannot do it by changing the .webp to .jpg, in the script, it gives an error. So or mp3tag change support(made a post in forum) or you have to make it by hand: download the file and change the extension.

romanoh commented 3 years ago

This is now suported: https://community.mp3tag.de/t/support-for-webp-image-previews/51592/11?u=romano

TheShadowRunner commented 3 years ago

Yes I saw Florian added support. But without auto-convertion to PNG or JPG it doesn't make much sense ?

romanoh commented 3 years ago

i did some test in the link you give and it woks. the auto conversion i think is another thing.

TheShadowRunner commented 3 years ago

Thanks for your feedback, apparently mp3tag is able to convert webp to jpg/png after all ? (how?) but it won't do it automatically. Or is the conversion something that is done at your level on the Source script ?

romanoh commented 3 years ago

I think there is no conversion, if you use the mp3tag software it gets the .webp file, and it saves it to the audio tags. and if you save it next to the audio file it stays .webp. It is one more file image suportedd: imagem

TheShadowRunner commented 3 years ago

Understood. The goal was being able to see webp image previews so this "issue" is fixed, thank you!