search

romanvm / django-tinymce4-lite

TinyMCE 4 editor widget for Django
MIT License
126 stars 47 forks source link

removed build_absolute_uri for docker compability #35

Closed gohanko closed 6 years ago

gohanko commented 6 years ago

When the package is used with docker, it will return the docker container name instead of the domain, which breaks the filebrowser in TinyMCE 4. To solve this, build_absolute_uri is removed and now uses implicit, relative but more flexible url.

codecov-io commented 6 years ago

Codecov Report

Merging #35 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files           6        6           
  Lines         229      229           
=======================================
  Hits          211      211           
  Misses         18       18
Impacted Files Coverage Δ
tinymce/views.py 86.88% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 817d298...f20f111. Read the comment docs.

romanvm commented 6 years ago

Thanks!

gohanko commented 6 years ago

Glad to contribute!