search

romanvm / django-tinymce4-lite

TinyMCE 4 editor widget for Django
MIT License
126 stars 47 forks source link

make example in doc more straightforward #51

Closed merwok closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #51 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files           6        6           
  Lines         233      233           
=======================================
  Hits          202      202           
  Misses         31       31

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f733c7d...cf91ed6. Read the comment docs.

romanvm commented 5 years ago

Why have you decided that this is a mistake?

merwok commented 5 years ago

Ha! I did not think about Ukrainian, I thought this was a typo (uk as a country code without language code, but I forgot that code for United Kingdom is gb)

merwok commented 5 years ago

So there is no typo, but I still offer this PR because I think it’s simpler to understand the examples if they are en_US and en alone.

romanvm commented 5 years ago

The choice of language codes in the example was deliberate and I don't see why they need to be changed.