search

romanvm / service.addic7ed

Subtitles addon for Kodi Mediacenter
20 stars 13 forks source link

Unable to determine episode data #21

Closed quthla closed 4 years ago

quthla commented 4 years ago

Issue description:

Filename parsing fails for "The Flash S05E05 mkv"

It's probably better to replace all blanks with dots before parsing the filename. Then the regexes could also be simplified because no more blanks need to be matched.

romanvm commented 4 years ago

Such name makes no sense because it has no extension. "The Flash S05E05.mkv" is parsed totally fine.

quthla commented 4 years ago

It's just the title, not the actual filename but it is what the addon tries to parse and fails obviously. I don't see any disadvantages replacing the spaces with dots, do you?

The full title is something like "The Flash S05E05 HDTV [...] mkv" but in either way, without a dot following season / episode, none of the regexes will match.

quthla commented 4 years ago

Is there any problem with my proposal?

I also noticed manual search will not work if it can't parse episode data. That also needs fixing

romanvm commented 4 years ago

Is there any problem with my proposal?

Yes, my lack of time. It's an edge case so it's low in my priorities list. Any help with pull requests is always welcome.