Closed antonsoroko closed 3 years ago
As far as I can see, this is not a proper pull request but a suggestion for changing some internal functionality of the addon. I appreciate the information and will consider it, but next time please do it via issues.
@romanvm sorry, but what exactly do you mean by "not a proper pull request"?
i did not delete old code (but moved it to comments) just for historical reason. i can delete it. might it be that you misread """
parts? (otherwise i dunno what exactly you consider wrong)
just say what exactly you want me to change and that's it.
also, the code was tested.
thank you.
Sorry, I've got confused by multiple multiline string literals. Please remove the old commented code.
@romanvm done. thank you.
Thank you for your contribution.
Looks like
path
in Player.GetItem does not return correct file path if file path is actually an url and it there was a redirect.code is borrowed from service.subtitles.opensubtitles https://github.com/juokelis/service.subtitles.opensubtitles/blob/Matrix/service.py#L137
for regular files - nothing changes as far as i can see in my tests.