search

romanvm / service.addic7ed

Subtitles addon for Kodi Mediacenter
20 stars 13 forks source link

Verify SSL to avoid throwing errors in the log #33

Closed mvn23 closed 1 year ago

mvn23 commented 1 year ago

Revert e8c0a6d. Not verifying SSL is bad practice and generates an error in Kodi's log file:

2023-05-19 00:14:42.492 T:1924     info <general>: service.subtitles.rvm.addic7ed: Searching for subs...
2023-05-19 00:14:42.638 T:1924    error <general>: /usr/lib/python3.11/site-packages/urllib3/connectionpool.py:1045: InsecureRequestWarning: Unverified HTTPS request is being made to host 'www.addic7ed.com'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/1.26.x/advanced-usage.html#ssl-warnings
                                                     warnings.warn(

2023-05-19 00:14:52.344 T:1924     info <general>: Skipped 1 duplicate messages..
romanvm commented 1 year ago

Addic7ed uses short-term LE certificates and they failed to renew a certificate in time at least once, as far as I can remember, causing the addon to throw exceptions. As for log messages, they don't really hurt anybody.

mvn23 commented 1 year ago

Ok, so now it's always disabled to handle an edge case. Would you accept a PR which makes it an option, possibly with a retry dialog in case of an SSL error?

romanvm commented 1 year ago

I don't see the point. This is a subtitle sceene website, not a card payment processor. The addon doesn't even handle user credentials, it just downloads some html pages and subs.