search

romanz / amodem

Audio MODEM Communication Library in Python
Other
950 stars 118 forks source link

Please update reedsolo #43

Closed lrq3000 closed 4 years ago

lrq3000 commented 4 years ago

Hello,

I am the current maintainer of reedsolo.

We have recently pushed major updates which increase speed and stability, but the API had to be changed.

If you are still using reedsolo, please ensure that you handle the 3 variables returned by reedsolo.

Before:

>>> rsc = RSCodec(12)
>>> tampered_msg = b'heXlo worXd\xed%T\xc4\xfdX\x89\xf3\xa8\xaa'
>>> decoded_msg = rsc.decode(tampered_msg)

Now:

>>> rsc = RSCodec(10)
>>> tampered_msg = b'heXlo worXd\xed%T\xc4\xfdX\x89\xf3\xa8\xaa'
>>> rmes, rmesecc, errata_pos = rsc.decode(tampered_msg)

As an alternative, you can setup your requirements.txt to require reedsolo<=0.3 to avoid the need to update.

romanz commented 4 years ago

Thanks for the update, but currently, this project doesn't use reedsolo package.