romanz / amodem

Audio MODEM Communication Library in Python
Other
965 stars 121 forks source link

Tests missing from 1.15.5 sdist #79

Closed mgorny closed 1 month ago

mgorny commented 1 month ago

Don't see any obvious change that could have caused this but it seems that the tests have disappeared from sdist in 1.15.5:

--- /tmp/a  2024-10-22 17:24:43.750352123 +0200
+++ /tmp/b  2024-10-22 17:24:46.400418547 +0200
@@ -25,34 +25,8 @@ amodem/recv.py
 amodem/sampling.py
 amodem/send.py
 amodem/stream.py
-amodem/tests/
-amodem/tests/test_alsa.py
-amodem/tests/test_audio.py
-amodem/tests/test_calib.py
-amodem/tests/test_common.py
-amodem/tests/test_configs.py
-amodem/tests/test_detect.py
-amodem/tests/test_dsp.py
-amodem/tests/test_equalizer.py
-amodem/tests/test_framing.py
-amodem/tests/test_sampling.py
-amodem/tests/test_stream.py
-amodem/tests/test_transfer.py
-amodem/tests/utils.py
-.bumpversion.cfg
-.gitignore
 LICENSE
 PKG-INFO
-.pylintrc
 README.rst
-scripts/
-scripts/autocalib.sh
-scripts/play.sh
-scripts/plot.py
-scripts/profile.sh
-scripts/record.py
-scripts/record.sh
-scripts/resample.py
 setup.cfg
 setup.py
-tox.ini
romanz commented 1 month ago

Thanks for reporting this issue!

romanz commented 1 month ago

IIUC, the current setup.py should not include tests in the source distribution, since it doesn't include the amodem.tests package.

romanz commented 1 month ago

Not sure how it did get included in previous releases :confused:

romanz commented 1 month ago

@mgorny please take a look at #80 - would that help fixing the issue?

mgorny commented 1 month ago

Not sure how it did get included in previous releases 😕

Yes, that was precisely what I was wondering about.

@mgorny please take a look at #80 - would that help fixing the issue?

Yes, tests seem to be included with that patch. Thanks!

romanz commented 1 month ago

Happy to help, and many thanks for maintaining amodem on Gentoo!

romanz commented 1 month ago

Merged and released https://pypi.org/project/amodem/1.15.6/

mgorny commented 1 month ago

Thanks! I can confirm that the new release contains and passes tests :-).