search

romanz / electrs

An efficient re-implementation of Electrum Server in Rust
MIT License
1.06k stars 395 forks source link

Feature: Support donation address configuration #992

Closed monkey-jsun closed 8 months ago

monkey-jsun commented 8 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

ElectrumX has a feature that allows one to configure a BTC address to receive donation. I actually have received some in the past.

Can electrs do the same?

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Kixunil commented 8 months ago

No and I would advise against doing so. ElectrumX is designed for publicly-facing servers, electrs is not. Unless you got donation from someone trusted this suggests you're trying to make public electrs instance. There's no DoS protection so it's best to use other software for it. And even if you've set up an authenticated tunnel with people you trust not to DoS your server it'd be better to use xpub or a LNURL. We could probably support xpub, the dependency is already there but still, the previous warning applies.

monkey-jsun commented 8 months ago

sounds good for its purpose. close now.