search

romanzipp / Laravel-Queue-Monitor

Monitoring Laravel Jobs with your Database
https://packagist.org/packages/romanzipp/laravel-queue-monitor
MIT License
698 stars 92 forks source link

Monitor queued jobs #131

Closed AsemAlalami closed 1 year ago

AsemAlalami commented 1 year ago

Monitor queued jobs https://github.com/romanzipp/Laravel-Queue-Monitor/discussions/62

also, I think it fixed the #76 issue

the PR adds "Initial Data" feature that initializes custom data to the monitor job

romanzipp commented 1 year ago

Nice work! Thanks! What do you think about adding a config option which needs to be implicitly enabled to enable monitoring queued jobs?

AsemAlalami commented 1 year ago

Yes, I can do that But wonder why someone wouldn't want to monitor queued jobs?!

romanzipp commented 1 year ago

I was thinking about how this could impact existing implementations which are coupled to the Monitor model. Anyways we will have to publish this change in a new major version so I'd still prefer a config option but we can leave it enabled by default.

AsemAlalami commented 1 year ago

I added a config option, but please take a look to my comment

romanzipp commented 1 year ago

Do you have anything to add or is this ready to merge?

AsemAlalami commented 1 year ago

I think it's ready to merge

romanzipp commented 1 year ago

Just a FYI, there are tests failing with the upcoming version. I'm looking into it but if you have an idea feel free to file a PR!

136