search

romaonthego / REFrostedViewController

iOS 7/8 style blurred view controller that appears on top of your view controller.
MIT License
2.97k stars 494 forks source link

REFrostedContainerViewController:viewWillAppear doesn't call [super viewWillAppear:animated] #108

Closed user454322 closed 9 years ago

user454322 commented 10 years ago

We are happy users of REFrostedViewController but my build analyzer keeps complaining about REFrostedContainerViewController:viewWillAppear not calling [super viewWillAppear:animated].

According to the documentation a call to super shall be done: If you override this method, you must call super at some point in your implementation.


This stackoverflow question What does [super viewWillAppear] do, and when is it required? is relevant.

user454322 commented 10 years ago

If there are no outstanding reasons for not calling super in REFrostedContainerViewController:viewWillAppear here is a pull request.

Our app, and the samples run OK with the PR in place.