romaonthego / RETableViewManager

Powerful data driven content manager for UITableView.
MIT License
2.48k stars 432 forks source link

Retain cycle through delegate #237

Closed sebastianludwig closed 8 years ago

sebastianludwig commented 8 years ago

The delegate property of RETableViewManager should be weak instead of assign (as delegates should always be). This way it's a retain cycle and any view controller using a RETableViewManager won't ever be deallocated (without taking extra actions).

ericertl commented 8 years ago

:+1:

sebastianludwig commented 8 years ago

My bad, of course assign does not create a retain cycle but the delegate property should be weak anyway to prevent dangling pointers.