Unknown RepositoryType display name 'ClearCase'

[fulgas]

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException at org.review_board.ereviewboard.ui.ReviewboardUiUtil.refreshRepositoryData(ReviewboardUiUtil.java:104) at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage.updateRepositoryData(ReviewboardQueryPage.java:162) at org.review_board.ereviewboard.ui.wizard.ReviewboardQueryPage.createControl(ReviewboardQueryPage.java:410) at org.eclipse.jface.wizard.Wizard.createPageControls(Wizard.java:174) at org.eclipse.jface.wizard.WizardDialog.createPageControls(WizardDialog.java:736) at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:608) at org.eclipse.jface.window.Window.create(Window.java:431) at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1089) at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:90) at org.eclipse.mylyn.internal.tasks.ui.actions.NewQueryAction.run(NewQueryAction.java:55) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4169) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3758) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1022) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:916) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:585) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:540) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584) at org.eclipse.equinox.launcher.Main.run(Main.java:1438) at org.eclipse.equinox.launcher.Main.main(Main.java:1414) Caused by: java.lang.reflect.InvocationTargetException at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:421) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028) at org.review_board.ereviewboard.ui.ReviewboardUiUtil.refreshRepositoryData(ReviewboardUiUtil.java:100) ... 39 more Caused by: java.lang.IllegalArgumentException: Unknown RepositoryType display name 'ClearCase' at org.review_board.ereviewboard.core.model.RepositoryType.fromDisplayName(RepositoryType.java:30) at org.review_board.ereviewboard.core.client.RestfulReviewboardReader.readRepositories(RestfulReviewboardReader.java:276) at org.review_board.ereviewboard.core.client.RestfulReviewboardClient$6.doLoadInternal(RestfulReviewboardClient.java:235) at org.review_board.ereviewboard.core.client.PagedLoader.doLoad(PagedLoader.java:70) at org.review_board.ereviewboard.core.client.RestfulReviewboardClient.getRepositories(RestfulReviewboardClient.java:239) at org.review_board.ereviewboard.core.client.RestfulReviewboardClient.updateRepositoryData(RestfulReviewboardClient.java:421) at org.review_board.ereviewboard.ui.ReviewboardUiUtil$1.run(ReviewboardUiUtil.java:92) at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)

[fulgas]

diff --git a/org.review_board.ereviewboard.core/src/org/review_board/ereviewboard/core/model/RepositoryType.java b/org.review_board.ereviewboard.core/src/org/review_board/ereviewboard/core/model/RepositoryType.java index 94da05d..b6d75e2 100644 --- a/org.review_board.ereviewboard.core/src/org/review_board/ereviewboard/core/model/RepositoryType.java +++ b/org.review_board.ereviewboard.core/src/org/review_board/ereviewboard/core/model/RepositoryType.java @@ -17,7 +17,7 @@ package org.review_board.ereviewboard.core.model; */ public enum RepositoryType {

• Bazaar("Bazaar"), ClearCase("Clear Case"), CVS("CVS"), Git("Git"), Mercurial("Mercurial"), Perforce("Perforce"), PerforceNetApp("Perforce NetApp"), PerforceVMWare("Perforce (VMware)"), PlasticSCM("Plastic SCM"), Subversion("Subversion");

• Bazaar("Bazaar"), ClearCase("ClearCase"), CVS("CVS"), Git("Git"), Mercurial("Mercurial"), Perforce("Perforce"), PerforceNetApp("Perforce NetApp"), PerforceVMWare("Perforce (VMware)"), PlasticSCM("Plastic SCM"), Subversion("Subversion");

  private final String displayName;

[rombert]

Thanks for taking the time to contribute. I think I'll update your fix a bit since I'm not sure why ClearCase is used in the official documentation but 'Clear Case' is sent so I'd rather support both.

I expect to merge this in the next couple of days.