search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Create review request in various circumstances. #115

Open dzurbuch opened 11 years ago

dzurbuch commented 11 years ago

I have multiple projects in my Eclipse workspace, corresponding to different branches of the project.

When I patch something, why is it not possible to include the changes from all projects in the diff that will be included in the review?

Why is it not possible to create a review request directly from a Change Set ? Is it definitely necessary to select the project?

Thanks in advance for your help.

rombert commented 11 years ago

It's not possible to create review requests from a changeset since this hasn't been implemented yet. At the moment I won't be able to submit major changes to the codebase due to lack of time.

OTOH I can assist with the implementation it you're willing and able to contribute.

dzurbuch commented 11 years ago

Thanks for your answer. And what about if I selected more projects in my workspace? It seems that only one is taken into account to generate the diff...

rombert commented 11 years ago

Yup, that's true, only one is selected by design.