search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Cannot display diff in Eclipse 4.3 (Kepler) #125

Closed philippecade closed 10 years ago

philippecade commented 10 years ago

eReviewBoard version 0.13.2.201303212018

The diff section stays empty when opening a review request in Eclipse 4.3. The error below is shown in the Error Log.

I have version 2.0.0.v20130612-0100 of the org.eclipse.mylyn.reviews.core plug-in. In this version, there is no createFileRevision method in this class.

java.lang.NoSuchMethodError: org.eclipse.mylyn.reviews.internal.core.model.ReviewsFactory.createFileRevision()Lorg/eclipse/mylyn/reviews/core/model/IFileRevision; at org.review_board.ereviewboard.core.model.reviews.ReviewModelFactory.createFileItems(ReviewModelFactory.java:60) at org.review_board.ereviewboard.ui.editor.ReviewboardDiffPart.createSubsection(ReviewboardDiffPart.java:150) at org.review_board.ereviewboard.ui.editor.ReviewboardDiffPart.createControl(ReviewboardDiffPart.java:115) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.initializePart(AbstractTaskEditorPage.java:1309) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.access$7(AbstractTaskEditorPage.java:1301) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage$14.run(AbstractTaskEditorPage.java:857) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:848) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:833) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createFormContentInternal(AbstractTaskEditorPage.java:720) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.refresh(AbstractTaskEditorPage.java:1437) at org.eclipse.mylyn.tasks.ui.editors.TaskEditor.refreshPages(TaskEditor.java:684) at org.eclipse.mylyn.internal.tasks.ui.actions.SynchronizeEditorAction$1$1.run(SynchronizeEditorAction.java:72) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4145) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3762) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426)

rombert commented 10 years ago

What version of Mylyn Reviews do you use? AFAIK there have been some breaking changes.

On Tue, Aug 20, 2013 at 4:54 PM, philippecade notifications@github.comwrote:

eReviewBoard version 0.13.2.201303212018

The diff section stays empty when opening a review request in Eclipse 4.3. The error below is shown in the Error Log.

I have version 2.0.0.v20130612-0100 of the org.eclipse.mylyn.reviews.core plug-in. In this version, there is no createFileRevision method in this class.

java.lang.NoSuchMethodError: org.eclipse.mylyn.reviews.internal.core.model.ReviewsFactory.createFileRevision()Lorg/eclipse/mylyn/reviews/core/model/IFileRevision; at org.review_board.ereviewboard.core.model.reviews.ReviewModelFactory.createFileItems(ReviewModelFactory.java:60) at org.review_board.ereviewboard.ui.editor.ReviewboardDiffPart.createSubsection(ReviewboardDiffPart.java:150) at org.review_board.ereviewboard.ui.editor.ReviewboardDiffPart.createControl(ReviewboardDiffPart.java:115) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.initializePart(AbstractTaskEditorPage.java:1309) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.access$7(AbstractTaskEditorPage.java:1301) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage$14.run(AbstractTaskEditorPage.java:857) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:848) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createParts(AbstractTaskEditorPage.java:833) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.createFormContentInternal(AbstractTaskEditorPage.java:720) at org.eclipse.mylyn.tasks.ui.editors.AbstractTaskEditorPage.refresh(AbstractTaskEditorPage.java:1437) at org.eclipse.mylyn.tasks.ui.editors.TaskEditor.refreshPages(TaskEditor.java:684) at org.eclipse.mylyn.internal.tasks.ui.actions.SynchronizeEditorAction$1$1.run(SynchronizeEditorAction.java:72) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4145) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3762) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:138) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:610) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591) at org.eclipse.equinox.launcher.Main.run(Main.java:1450) at org.eclipse.equinox.launcher.Main.main(Main.java:1426)

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125 .

http://robert.muntea.nu/

philippecade commented 10 years ago

I am using version Mylyn version 3.9.0 v20130612-0100.

rombert commented 10 years ago

I just wanted to say that I haven't forgotten about this. The problem happens because Mylyn Reviews has made some incompatible changes between Mylyn 3.8 and Mylyn 3.9 .

I will adapt to those changes, but not all are mechanical, and it will take a bit more. Hopefully I'll have a version up for testing later this week.

alekzander75 commented 10 years ago

Hi rombert. Just wanted to mention that I'm getting the same Error creating task editor part: "org.review_board.ereviewboard.ui.editor.ReviewRequestEditorPage.parts.diff" error (same stack trace).

I'm glad to hear you're still working on this plugin :)

Thank you for all your work!

1256015 commented 10 years ago

Hi rombert, wish to check with you is there any version to solve this released soon? THanks!

salashnik commented 10 years ago

+1. With this bug plugin really useless :(

rombert commented 10 years ago

Sorry guys, I know it's taking way too long to fix this. One final API change is a bit problematic for me, and I'm trying to work around it.

I haven't forgotten about this.

1256015 commented 10 years ago

Hi just want to know if I am able to downgrade Mylyn to 3.8, will this solve the issue?

rombert commented 10 years ago

Downgrading should solve it, yes.

On Tue, Nov 12, 2013 at 9:11 AM, 1256015 notifications@github.com wrote:

Hi just want to know if I am able to downgrade Mylyn to 3.8, will this solve the issue?

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-28273061 .

http://robert.muntea.nu/

selsemore commented 10 years ago

Is anything happening with this issue?

rombert commented 10 years ago

Can't promise anything by the end of the year unfortunately.

selsemore commented 10 years ago

Thanks, Robert. I took a look at this, hoping maybe I could help out with a patch. But I see what you're up against with all the refactoring and renamed classes! More than I'm up for taking on at this time too. Do you have any hope that there will eventually be a single version of eReviewBoard that is compatible with both the latest Mylyn as well as the earlier Mylyn versions that are currently supported (i.e., 3.8)?

rombert commented 10 years ago

Right now I don't think we can support two Mylyn Reviews streams with a single code base. So unfortunately when I will update the plugins to work with the Kepler versions they will no longer work with the older ones.

Of course, if you don't want the SCM integration then you can use either one, since the Mylyn Tasks dependencies are more stable.

On Tue, Dec 10, 2013 at 8:50 PM, selsemore notifications@github.com wrote:

Thanks, Robert. I took a look at this, hoping maybe I could help out with a patch. But I see what you're up against with all the refactoring and renamed classes! More than I'm up for taking on at this time too. Do you have any hope that there will eventually be a single version of eReviewBoard that is compatible with both the latest Mylyn as well as the earlier Mylyn versions that are currently supported (i.e., 3.8)?

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-30255948 .

http://robert.muntea.nu/

topikachu commented 10 years ago

Latest Mylyn supports multiple eclipse version. http://www.eclipse.org/mylyn/new/ Mylyn 3.10 requires Java 1.6 or later and supports Eclipse 3.8, 4.3 or 4.4. Eclipse 3.6 is now the base compilation target,

So it's possible to target to latest Mylyn and still works on some 'old' eclipse version.

rombert commented 10 years ago

That's a good point. What I meant to say is that once we target a new Mylyn version, we won't be compatible with the old ones.

rombert commented 10 years ago

Closed with #128 , many thanks to @topikachu !

My initial tests look good, I need to test some more though before cutting a release.

alekzander75 commented 10 years ago

great!

gozhang7 commented 10 years ago

@rombert So does this problem solved? Because with the latest version of eReviewBoard, I still encountered the same problem. Thanks for any help!

rombert commented 10 years ago

@zhangsan8006 - if I point you to a intermediate version which you can install in Eclipse, would you be willing to test it?

I have fixed this bug but the new version is not yet released.

gozhang7 commented 10 years ago

@rombert I am more than happy to test it for you. BTW do you noticed the issue I raised up on Github? I can not create a review request base on my eclipse project which is really bad... Thanks!

On Tue, Mar 11, 2014 at 10:21 AM, Robert Munteanu notifications@github.comwrote:

@zhangsan8006 https://github.com/zhangsan8006 - if I point you to a intermediate version which you can install in Eclipse, would you be willing to test it?

I have fixed this bug but the new version is not yet released.

Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-37300421 .

rombert commented 10 years ago

@zhangsan8006 - yes, I've seen it, but let's see what happens when you try the latest build from master. I'll set up a testing build for you today.

gozhang7 commented 10 years ago

@robert thanks for your help!

On Tue, Mar 11, 2014 at 10:41 AM, Robert Munteanu notifications@github.comwrote:

@zhangsan8006 https://github.com/zhangsan8006 - yes, I've seen it, but let's see what happens when you try the latest build from master. I'll set up a testing build for you today.

Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-37302807 .

rombert commented 10 years ago

@tibeT7 - can you try a build from https://github.com/rombert/ereviewboard/releases/tag/ereviewboard-0.14.0-SNAPSHOT ? You should download the zip file - it's a local update site and update your installation from it.

I recall that you mentioned ReviewBoard 2.0 in the other issue, I haven't tested that stream yet so there may be suprises there as well.

gozhang7 commented 10 years ago

@rombert, thanks for your build and the "can not see diff" problem has been solved. But I still can not create a code review base on a eclipse project. The error is "Failed creating new review request : The file was not found in the repository." I am confused which repository is it complaining about? The SVN repository? The repository in RB? Or the local workspace. BTW I am using RB2.0 RC1, thanks, I really appreciate your help!

On Tue, Mar 11, 2014 at 5:47 PM, Robert Munteanu notifications@github.comwrote:

@tibeT7 https://github.com/tibeT7 - can you try a build from https://github.com/rombert/ereviewboard/releases/tag/ereviewboard-0.14.0-SNAPSHOT? You should download the zip file - it's a local update site and update your installation from it.

I recall that you mentioned ReviewBoard 2.0 in the other issue, I haven't tested that stream yet so there may be suprises there as well.

Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-37352923 .

rombert commented 10 years ago

So it's still broken :| . Let's continue discussing on the issue you originally reported.

On Wed, Mar 12, 2014 at 3:52 PM, Allen Zhang notifications@github.comwrote:

@rombert, thanks for your build and the "can not see diff" problem has been solved. But I still can not create a code review base on a eclipse project. The error is "Failed creating new review request : The file was not found in the repository." I am confused which repository is it complaining about? The SVN repository? The repository in RB? Or the local workspace. BTW I am using RB2.0 RC1, thanks, I really appreciate your help!

On Tue, Mar 11, 2014 at 5:47 PM, Robert Munteanu notifications@github.comwrote:

@tibeT7 https://github.com/tibeT7 - can you try a build from

https://github.com/rombert/ereviewboard/releases/tag/ereviewboard-0.14.0-SNAPSHOT? You should download the zip file - it's a local update site and update your installation from it.

I recall that you mentioned ReviewBoard 2.0 in the other issue, I haven't tested that stream yet so there may be suprises there as well.

Reply to this email directly or view it on GitHub< https://github.com/rombert/ereviewboard/issues/125#issuecomment-37352923>

.

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/125#issuecomment-37410024 .

http://robert.muntea.nu/