search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

port ereviewboard to mylyn 3.10 #128

Closed topikachu closed 10 years ago

topikachu commented 10 years ago

A quick and dirty fix to port ereviewboard to mylyn 3.10.

  1. All junit plugin tests are green
  2. Try on reviewboard 1.7.20 + svn What works create/publish review request create top/bottom review create inline review ship it What not works attachment ... ?
  3. Including a fix for discarding review draft
buildhive commented 10 years ago

Robert Munteanu » ereviewboard #31 FAILURE Looks like there's a problem with this pull request (what's this?)

rombert commented 10 years ago

Wow, nice :-)

You also need to update the .target file to make the Maven build work - this is why the Travis build failed. Are you familiar with target files? If not, I can post a diff today for you to apply to your pull request.

On Thu, Dec 19, 2013 at 12:23 PM, BuildHive notifications@github.comwrote:

Robert Munteanu » ereviewboard #31https://buildhive.cloudbees.com/job/rombert/job/ereviewboard/31/FAILURE Looks like there's a problem with this pull request (what's this?) https://www.cloudbees.com/what-is-buildhive

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/pull/128#issuecomment-30918576 .

http://robert.muntea.nu/

topikachu commented 10 years ago

please send me the target file. :)

rombert commented 10 years ago

https://gist.github.com/rombert/8046777

On Thu, Dec 19, 2013 at 3:23 PM, GongYi notifications@github.com wrote:

please send me the target file. :)

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/pull/128#issuecomment-30927777 .

http://robert.muntea.nu/

buildhive commented 10 years ago

Robert Munteanu » ereviewboard #33 FAILURE Looks like there's a problem with this pull request (what's this?)

buildhive commented 10 years ago

Robert Munteanu » ereviewboard #34 SUCCESS This pull request looks good (what's this?)

topikachu commented 10 years ago

I don't know what's wrong on the travis-ci. I use mvn install on my local PC without any issue :(

rombert commented 10 years ago

Looks like the build is fine now! I'll do some testing this weekend hopefully.

On Fri, Dec 20, 2013 at 7:56 AM, GongYi notifications@github.com wrote:

I don't know what's wrong on the travis-ci. I use mvn install on my local PC without any issue :(

— Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/pull/128#issuecomment-30990483 .

http://robert.muntea.nu/

rombert commented 10 years ago

Merged, thank you very much!

I've done some initial tests with subversion and things look good. I am no longer able to post patches, but I can't relate that to your change. I'll need to do some more testing but this is definitely a reason to make a new release.

Robert