search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Can not show diff and create review request #130

Closed gozhang7 closed 9 years ago

gozhang7 commented 10 years ago

Hi,

I am glad you developed this plugin to help the integration with Eclipse and ReviewBoard, it`s very cool! But I have a few problems for now.

  1. Within a review request, the diff tab is empty. And I have saw some similar issues and I am wondering, is this problem solved? I already downloaded the latest version of eReviewBoard(0.13.2) and connector to Mylyn
  2. I have checkout a project from SVN, and want to create a review request within Eclipse. So I went to team->create Review Request, and after I hit the "finish" button I got a "Failed creating new review request : The file was not found in the repository." error. I really got confused about this error and I have abide by the instruction on your wiki page - "The URL for the SVN repository defined in Eclipse needs to match exactly the URL for the SVN repository defined in ReviewBoard.". Addtional information: I am using ReviewBoard 2.0 RC1, eclipse 4.2 and SVN 1.8.

Thanks for any help!

rombert commented 10 years ago

Can you try with Reviewboard 1.7.x ? I have not yet tested with 2.0.x , maybe that's an issue.

That error sounds like the file you're trying to submit exists locally but not in the repo, can you validate if that's the case? It would help if you added a screenshot of the files you've chosen to upload, as shown in the review request wizard.

gozhang7 commented 10 years ago

Hi,

Thank for your response. And in my opinion, maybe there is something wrong with the paths. Attached is the screenshot of "create new review request page". My project`s svn repository path is: /svn/Tools/trunk/ReviewBoardTest/ And I guess when I try to create a new code review, the "eReviewBoard" will connect to the SVN server and check if that file exists right? So it may simply treat {svn repository "/svn/Tools/trunk"(which you can see in the attached image)

Best, Gong

On Thu, Mar 13, 2014 at 5:54 PM, Robert Munteanu notifications@github.comwrote:

Can you try with Reviewboard 1.7.x ? I have not yet tested with 2.0.x , maybe that's an issue.

That error sounds like the file you're trying to submit exists locally but not in the repo, can you validate if that's the case? It would help if you added a screenshot of the files you've chosen to upload.

On Mon, Mar 10, 2014 at 9:19 PM, Allen Zhang notifications@github.comwrote:

Hi,

I am glad you developed this plugin to help the integration with Eclipse and ReviewBoard, it`s very cool! But I have a few problems for now.

  1. Within a review request, the diff tab is empty. And I have saw some similar issues and I am wondering, is this problem solved? I already downloaded the latest version of eReviewBoard(0.13.2) and connector to Mylyn
  2. I have checkout a project from SVN, and want to create a review request within Eclipse. So I went to team->create Review Request, and after I hit the "finish" button I got a "Failed creating new review request : The file was not found in the repository." error. I really got confused about this error and I have abide by the instruction on your wiki page - "The URL for the SVN repository defined in Eclipse needs to match exactly the URL for the SVN repository defined in ReviewBoard.". Addtional information: I am using ReviewBoard 2.0 RC1, eclipse 4.2 and SVN 1.8.

Thanks for any help!

Reply to this email directly or view it on GitHub< https://github.com/rombert/ereviewboard/issues/130> .

http://robert.muntea.nu/

Reply to this email directly or view it on GitHubhttps://github.com/rombert/ereviewboard/issues/130#issuecomment-37591634 .

rombert commented 10 years ago

This is definitely an error, and probably a recent regression in the diff generation code.

I've pushed a change which at least passes the proper error message down the the user. I hope to narrow it down and have a fix soon.

rombert commented 10 years ago

The root of the cause is the diff indeed, but that code has not changed in over 2 years.

Asked for clarifications on the reviewboard support group: Reviewboard not reading file locations from patch index .

rombert commented 10 years ago

Since I got no answer in the reviewboard group, I am trying to get some help form the subclipse devs, since the way the diff is generated seems to be incorrect: [Subclipse-users] ISVNClientAdapter.diff - how are the paths calculated?

I have a unit test written and a hopefully simpler implementation of the DiffCreator, but unfortunately the plug-in test and the actual plug-in behave differently.