rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

"Did not find session cookie in response" when Validating Settins #45

Closed misterbeebee closed 13 years ago

misterbeebee commented 13 years ago

During Repository setup, When I "Validate Settings" to my company's Review Board server, I get this error: "Did not find session cookie in response"

Browser based access from the same client machine to the same server works fine.

What does that mean? How can I diagnose?

I mean, it's clear that this is where the error happens:

        // look for session cookie
        for (Cookie cookie : httpClient.getState().getCookies())
            if (cookie.getName().equals("rbsessionid"))
                foundSessionCookie = cookie.getValue();

        if ( foundSessionCookie == null )
            throw new ReviewboardException("Did not find session cookie in response");

but...why?

Possibly related: On some machines, (Firefox on Windows 7 in my office), I can't browse into ReviewBoard, because the server reports an error that my browser is not accepting cookies. Chrome on the same machine can log in fine, though.

On the machine (Mac OS X 10.6,) where I am running Eclipse (Helios), though, logging in and out with Firefox works with no problems.

I have no Proxy set up, but I am connecting to the server via a VPN

rombert commented 13 years ago

What RB version are you using? And how is the server configured regarding anonymous users?

rombert commented 13 years ago

Oh, and what version of the Eclipse plugin are you using?

misterbeebee commented 13 years ago

Review Board version 1.5 beta 2 (I should probably upgrade.)

Plugin version is today's version in Eclipse Marketplace: Mylyn Connector: ReviewBoard 0.7.3.201103021210

Under /admin/settings/authentication/ I see:

[Checked] Allow anonymous read-only access
Authentication Method: Standard Registration

Basic Authentication Settings [Checked] Enable registration

I can change this to try other options if you suggest.

misterbeebee commented 13 years ago

Upgrading to ReviewBoard 1.5.4 resolves the problem.

I apologize for not doing that first. In my defense, Review Board's documentation does not contain clear upgrade instructions: rb-site upgrade doesn't suffice, the ReviewBoard code itself needed an upgrade first: easy_install --upgrade ReviewBoard

I got a Mylin NullPointerException afterward, but Mylin+eRB seems to work now.

Thanks for a great tool!

rombert commented 13 years ago

You're welcome. FWIW the upcoming 0.8.0 should fix that NPE and provide an overall better experience.