search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Can you support post-commit review by specifying rev range? #74

Open haebin opened 12 years ago

haebin commented 12 years ago

Hi, can you support post-commit review by specifying rev range instead of posting the local diff? Thank you very much~

rombert commented 12 years ago

This is related to subclipse, right?

haebin commented 12 years ago

Yes, it's relevant to subclipse. Also, are there any chances of supporting subversive?

rombert commented 12 years ago

I am not sure about Subversive , as I do not use it . If you need Subversive support, adding support for the compare editor should be pretty simple, see the code at https://github.com/rombert/ereviewboard/blob/master/org.review_board.ereviewboard.subclipse.core/src/org/review_board/ereviewboard/subclipse/core/internal/actions/SubclipseSCMFileContentsLocator.java .

If you want integration for creating reviews and posting updated diffs, the API is not solid yet, but you can have a look at the https://github.com/rombert/ereviewboard/tree/master/org.review_board.ereviewboard.subclipse.ui project .

haebin commented 12 years ago

Yup, that's why I forked your project. Thank you very much~ :D

rombert commented 12 years ago

Great! Looking forward to see the results of your fork. If you need to add new external dependencies to the build, edit the ereviewboard.target file.

On Tue, Oct 25, 2011 at 4:28 PM, Frederick Haebin Na reply@reply.github.com wrote:

Yup, that's why I forked your project. Thank you very much~ :D

Reply to this email directly or view it on GitHub: https://github.com/rombert/ereviewboard/issues/74#issuecomment-2517052

Sent from my (old) computer

rombert commented 12 years ago

If you do plan to add anything more than compare editor integration, that is implementing and contributing TaskDiffAction , please start a discussion on the google group. There is some reuse which can be achieved by pulling up code from the subclipse.ui plugin, but I never got around to do that.