search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Make filling target user and group optional #78

Open ginkel opened 12 years ago

ginkel commented 12 years ago

Our Review Board installation is set up to automatically assign reviewers to new review requests using Review Board's "Default Reviewers" feature.

Unfortunately, EReviewboard expects that at least one of the "Target user" or "Target group" fields contains data when publishing a review request.

Would it be possible to make these fields optional if a matching default reviewer is maintained for the request?

rombert commented 12 years ago

Thanks for the report. Would you be willing to contribute a patch?

ginkel commented 12 years ago

I can't promise anything, but I will check with my customer whether that would be an option.

ginkel commented 12 years ago

Hm... Reading through the Review Board API documentation [1], there seems to be no API to figure out whether there are any default reviewers configured for a given set of files.

As a quick workaround, one could make those fields optional. What would be nicer is a way to query RB for a set of paths and retrieve a list of default reviewers and groups for these. I'll head over to the RB mailing list to get some input...

[1] http://www.reviewboard.org/docs/manual/dev/webapi/

rombert commented 12 years ago

If the default reviewers are not avaiable through the web api, can you verify that review requests can get through with no target user/group if a default user is set? If that is the case, we can make the user/group not required and allow submission.

We should also inform the user that a group / user is required if no defaults are specified by review board by setting a warning message on wizard when the summary and description are filled in.