Some SVN henacements - Githubissues

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board

46 stars 31 forks source link

Some SVN henacements #80

Closed McFoggy closed 12 years ago

McFoggy commented 12 years ago

Hi,

We've started to use your plugin and needed some enhancements for SVN. Here are the improvements:

allow "ADDED" files (new files added to SVN but not yet commited) to be part of patch when creating a review
initialize branch name for HTTP SVN repositories
autocompletion (CTRL+SPACE) actually on the fields user & groups on the creation review page

Hope you'll find this usefull.

Matthieu Brouillard

rombert commented 12 years ago

Thanks for the submission! I'll have a look at it during the following days.

McFoggy commented 12 years ago

Hi, just to notify that the latest commit correct the autocompletion that was deactivated by accident by the introduction of the Ctrl+Space. It works fine now.

rombert commented 12 years ago

This looks great. A few comments inline. It would help if you would submit a pull request per 'topic', as I would be able to merge them sooner.

McFoggy commented 12 years ago

I am really new to git, but you're right I'll do several branches next time to clearly & functionaly separate the enhancements.

rombert commented 12 years ago

I've just commited a couple of ideas originating from your contribution. We now have completion proposals with full names for users and groups and Ctrl-Space activation of completion, together with a light bulb decorator which is shown when the field is focused.

If you're still willing to submit enhacements, I think that the branch dialog would a good next candidate, probably as a completion , and not pre-filling.

Thanks again for the submission.