search

rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Svn repository mismatch because of different usernames #90

Closed rveloso closed 11 years ago

rveloso commented 12 years ago

it seems there's a "bug" in your reviewboard plugin in that it tries to match the svn repository complete string: e.g. svn+ssh://user1@domain.com/repo will not be considered the same repository as svn+ssh://user2@domain.com/repo, even though only the usernames differ.

if i have a generic user configured in reviewboard server and im checking-in code locally using another username, the plugin wont work in eclipse, and it will throw an error saying the repositories dont match. Could you patch this to ignore the username part of the svn string so it wont originate an error when trying to add a review request?

rombert commented 12 years ago

Thanks for the report. I'll hopefully have a look in the near future.

rveloso commented 12 years ago

In particular, this is the message im getting:

"No SVN repository defined in ReviewBoard for path svn+ssh://user1@server.com/svnroot. Please ensure that the repository URL from Eclipse matches the one from ReviewBoard."

and the reviewboard server is configured w/ repo svn+ssh://user2@server.com/svnroot

rombert commented 12 years ago

I think the safest would be to detect SVN repositories based on their UUID, so that's what I'm going to do. There is no workaround for now unforunately.

rveloso commented 12 years ago

indeed, that would be great

jacobweber commented 12 years ago

+1. This would also be useful if you have multiple ways to access a repository (e.g. http and svn+ssh).

gokulakannan commented 11 years ago

Any possible workaround for SVN repository to work?

rombert commented 11 years ago

Any possible workaround for SVN repository to work?

Perhaps adding a second SVN repository to Eclipse using the 'public' user used for RB?null

rombert commented 11 years ago

A snapshot update site is now be available at https://ereviewboard.ci.cloudbees.com/job/eReviewBoard/113/org.review_board.ereviewboard$org.review_board.ereviewboard.update/ ( download the -assembly.zip file ).

I'd appreciate someone taking it for a test run - it works for me but I'd rather be sure before releasing.

jacobweber commented 11 years ago

FYI, this seems to work for me with 0.13.2 -- I have RB configured with an SVN repository using https, and my project is checked out using svn+ssh. I'm able to submit a review request.

rombert commented 11 years ago

Great, thanks :-)