rombert / ereviewboard

A mylyn-based Eclipse integration for Review Board
46 stars 31 forks source link

Support Multiple Line Selection for Comments #92

Open RunnersReign opened 12 years ago

RunnersReign commented 12 years ago

When making a comment on a code diff using the Eclipse Plugin, I would normally select multiple lines that I want to make the comment on and then make the comment on that block of text. This is great for instances where you want to show the entire section of code that will cause the error. I finding however that the the comment only refers to the first line of the selection when creating the comment, not the entire highlighted selection.

Steps to Reproduce:

If you open the review within the Review Board web application, you can see only the first line selected is shown as having a comment associated with it.

It would be a great if all lines selected would be commented on instead of just the first line.

dsevero commented 7 years ago

+1

sgarcesg1 commented 7 years ago

+1

sebastienatplumbee commented 7 years ago

+1

jzhuge commented 7 years ago

+1

arvinthj commented 7 years ago

+1

sergibondarenko commented 7 years ago

+1

lorey-casacop commented 7 years ago

+1

savostjanovs commented 7 years ago

+1

bam0382 commented 7 years ago

+1

Introvertuous commented 7 years ago

+1

lane-flexe commented 7 years ago

+1

shukla2112 commented 7 years ago

+1

peter-toms commented 7 years ago

+1

brazilbean commented 7 years ago

+1

brazilbean commented 7 years ago

And please include this feature in enterprise git accounts as well.

brooksandrew commented 7 years ago

+1 (including for GH enterprise)

pruthvidesai commented 7 years ago

+1

taoning2014 commented 7 years ago

+1

chronidev commented 7 years ago

+1

davorkovacic-abh commented 7 years ago

+1

georgysavva commented 7 years ago

+1

renatgalimov commented 7 years ago

+1

jbalca commented 7 years ago

+1

ghost commented 7 years ago

+1

arivinay commented 7 years ago

+1

gytibor commented 7 years ago

+1

kilogold commented 7 years ago

+1

christinechou commented 7 years ago

+1

vshwnth2 commented 7 years ago

+1

brassy- commented 7 years ago

+1

cghirardi commented 7 years ago

+1

dapenguin commented 7 years ago

+1

seaninryan commented 7 years ago

+1

SandeepPissay commented 7 years ago

+1.

verakutsenko commented 7 years ago

+1

olsaki commented 7 years ago

👍

cyberbob commented 7 years ago

+1

mec07 commented 7 years ago

+1

Terbiy commented 7 years ago

+1

atanasdb commented 7 years ago

+1

Damien-Black commented 7 years ago

+1

JuliusDegesys commented 7 years ago

+1 (including for GH enterprise)

sbleihp5 commented 7 years ago

+1

jessesarn commented 7 years ago

+1

ignacio83 commented 7 years ago

+1

thomasofdenmark commented 7 years ago

+1

kosiakMD commented 7 years ago

+1

mikabytes commented 7 years ago

+1

srnypst commented 7 years ago

+1

johnnycoinbase commented 7 years ago

+1