search

romcal / romcal-examples

A few examples of projects using Romcal.
MIT License
4 stars 4 forks source link

feat: update react site from romcal.js.org #7

Closed emagnier closed 6 months ago

emagnier commented 6 months ago

In this PR, I've updated the React example project to match the functionality level of romcal.js.org (forget about the source branch I pushed to the romcal.github.io repo, I've actually deleted it).

Just FYI, I've just updated romcal.js.org manually, from the build result of this branch.

How do you think we should handle this? In the future, we might want to separate the example projects from the romcal.js.org site (to keep the example projects simple). However, we can use these example projects as a basis for now, while we plan to improve later (hopefully, I'd like to work on a more comprehensive website, possibly using Docusaurus, including romcal documentation and allowing navigation somehow similar to what we have now).

If you need admin access to the romcal.github.io or romcal-examples repo, to reorganize branches and workflow as you see fit (and without waiting for approval while setting things up), just let me know.

emagnier commented 6 months ago

Also, feel free to close this PR, and reintegrate the features differently if you prefer, especially since you have another PR open https://github.com/romcal/romcal-examples/pull/6 with quite a bit of refactoring.

TobiTenno commented 6 months ago

@emagnier i'll integrate this into #6 and get both merged in a few hours 👍

I think we'll still need the ACTIONS_DEPLOY_KEY secret that the action needs