rome / tools

Unified developer tools for JavaScript, TypeScript, and the web
https://docs.rome.tools/
MIT License
23.8k stars 665 forks source link

🐛 VSCode Extension shows errors for projects without Rome installed #3271

Closed probablykasper closed 1 year ago

probablykasper commented 1 year ago

Environment information

macOS 10.15.7, x86

What happened?

The Rome extension is giving lint errors for projects where I don't have Rome installed

Expected result

Only run Rome if Rome is actually used in the project so Rome doesn't interfere with the project's linter/formatter

Code of Conduct

ematipico commented 1 year ago

Assuming that the Rome extension expects to work even when a rome.json is not present, how would you expect to "turn off" Rome for a project inside the VSCode extension? Via settings?

probablykasper commented 1 year ago

I would expect Rome to only be enabled if Rome is used. I'm not sure how eslint or prettier do it, but I don't get any errors from them. Besides, how would the extension know what Rome version to use if Rome isn't installed in the project?

ZachHaber commented 1 year ago

I currently use Rome only on one particular project, so I have the extension disabled globally, and then enable it for that workspace. I tend to do that for most of my framework specific extensions (i.e. Volar, Angular, etc) to prevent them from taking up too much start up time generically. Personally, I like that I don't have to necessarily install the Rome cli to use Rome extension, though if my project was being edited by multiple people, I'd probably have to anyway for consistency.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 14 days with no activity.

ematipico commented 1 year ago

I am going to close this issue. We acknowledged the use case and we plan to work on it, but that's not something that we consider as a quick fix, because it requires some work on the resolution of the configuration file.