Closed nissy-dev closed 1 year ago
Name | Link |
---|---|
Latest commit | f4c46bd01e0485d90c349b3612b04be90d0fffed |
Latest deploy log | https://app.netlify.com/sites/docs-rometools/deploys/64cfa5830a95450008926aba |
Test result | main count |
This PR count | Difference |
---|---|---|---|
Total | 48863 | 48863 | 0 |
Passed | 47810 | 47808 | ❌ ⏬ -2 |
Failed | 1053 | 1055 | ❌ ⏫ +2 |
Panics | 0 | 0 | 0 |
Coverage | 97.84% | 97.84% | -0.00% |
Test result | main count |
This PR count | Difference |
---|---|---|---|
Total | 40 | 40 | 0 |
Passed | 37 | 37 | 0 |
Failed | 3 | 3 | 0 |
Panics | 0 | 0 | 0 |
Coverage | 92.50% | 92.50% | 0.00% |
Test result | main count |
This PR count | Difference |
---|---|---|---|
Total | 6212 | 6212 | 0 |
Passed | 1764 | 1764 | 0 |
Failed | 4448 | 4448 | 0 |
Panics | 0 | 0 | 0 |
Coverage | 28.40% | 28.40% | 0.00% |
Test result | main count |
This PR count | Difference |
---|---|---|---|
Total | 639 | 639 | 0 |
Passed | 573 | 573 | 0 |
Failed | 66 | 66 | 0 |
Panics | 0 | 0 | 0 |
Coverage | 89.67% | 89.67% | 0.00% |
Test result | main count |
This PR count | Difference |
---|---|---|---|
Total | 17224 | 17224 | 0 |
Passed | 13121 | 13121 | 0 |
Failed | 4103 | 4103 | 0 |
Panics | 0 | 0 | 0 |
Coverage | 76.18% | 76.18% | 0.00% |
I checked if rome handle using and await using declaration correctly in playground, but it didn't handle. I'm looking into what happened.
I checked if rome handle using and await using declaration correctly in playground, but it didn't handle. I'm looking into what happened.
You have to update parse_declaration_clause
too
Thank you for your reviews! I will try to fix in a few days.
You have to update parse_declaration_clause too
I seem "using" cannot be allowed inside a declaration_clause.
I update codes by following comments and this PR is ready for the review again!
The CI failure is related to https://github.com/astro-community/astro-compress/issues/163
Such a good work!
Summary
Fix a part of #4646
This PR is basic support for using and await using declaration. After merging this PR, I will check if we need to modify more existing lint rules and create another PR for resolving todo tests.
Test Plan
I added some parser tests based on esbuild test cases ref: https://github.com/evanw/esbuild/blob/af7cfc5d0d5108aae0f9f02447f08761e9b604f2/internal/js_parser/js_parser_test.go#L6090