search

romedtino / simple-wyze-vac

Home Assistant Custom Component for Wyze Vacuum
48 stars 8 forks source link

deprecated supported features #77

Closed dwdonnelly closed 4 months ago

dwdonnelly commented 6 months ago

Describe the bug The following is report in Home Assistant Logs:

Logger: homeassistant.helpers.entity Source: helpers/entity.py:1567 First occurred: 6:44:52 AM (4 occurrences) Last logged: 7:46:52 AM

Entity None (<class 'custom_components.simple_wyze_vac.vacuum.WyzeVac'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <VacuumEntityFeature.STOP|RETURN_HOME|FAN_SPEED|BATTERY|STATUS|SEND_COMMAND|LOCATE|MAP|START: 11256>, please report it to the author of the 'simple_wyze_vac' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

To Reproduce N/A

Expected behavior This msg to be resolved.

Screenshots N/A

Simple Wyze Vac Version 1.8.9....That comes from the HACS web view.

Wyze Vacuum Firmware Version 1.6.202 (I have two wyze vacuums, both are at the same version level)

Home Assistant Version Core 2024.2.1 Supervisor 2024.01.1 Operating System 11.5 Frontend 20240207.1

Additional context Appreciate your help to correct this issue.

tdavis75 commented 6 months ago

I can confirm that I'm seeing the same thing in my environment.

dwdonnelly commented 6 months ago

@tdavis75 Hopefully we will see a resolution from @romedtino.

dwdonnelly commented 5 months ago

@romedtino Appreciate any update on this issue. Thanks.

xStellarZ commented 5 months ago

I'm not sure @romedtino will be fixing this as he hasn't been active in some time. I need this integration to work so I will fork and fix this if it breaks. @tdavis75 @dwdonnelly

dwdonnelly commented 5 months ago

@xStellarZ Many thanks. @tdavis75 For your situational awareness

As I am unfamiliar with the "fork" process, how does this work and where should I or we follow up on? Many thanks in advance for your help.

xStellarZ commented 5 months ago

@xStellarZ Many thanks. @tdavis75 For your situational awareness

As I am unfamiliar with the "fork" process, how does this work and where should I or we follow up on? Many thanks in advance for your help.

Went ahead and made a fork, will be updated here if/when I need to implement the changes: https://github.com/xStellarZ/simple-wyze-vac

romedtino commented 5 months ago

Hey, been quite busy with work but I wouldn't worry about that warning for now. We have until January'25 to make the changes and the entity changes aren't too hard to change but if anyone is interested in doing a PR of the change by all means 👍

dwdonnelly commented 5 months ago

Glad to hear the change should be easy and we have some time. I appreciate the offer of the PR, but I am not technically skilled enough to attempt that.

For now, I will leave such things to the experts.

For planning purposes, when might you expect to work on this issue? I don’t want to pester you.

Thanks !

Dave

From: Jerome Tolentino @.> Sent: Wednesday, March 20, 2024 9:41 PM To: romedtino/simple-wyze-vac @.> Cc: dwdonnelly @.>; Mention @.> Subject: Re: [romedtino/simple-wyze-vac] deprecated supported features (Issue #77)

Hey, been quite busy with work but I wouldn't worry about that warning for now. We have until January'25 to make the changes and the entity changes aren't too hard to change but if anyone is interested in doing a PR of the change by all means 👍

— Reply to this email directly, view it on GitHub https://github.com/romedtino/simple-wyze-vac/issues/77#issuecomment-2011204885 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDT7CO4VSIKGT62VV4RNCDYZJQD5AVCNFSM6AAAAABDLDF6KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGIYDIOBYGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKDT7CN7YOS5K2RL34ENV6LYZJQD5A5CNFSM6AAAAABDLDF6KCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTX4CGRK.gif Message ID: @. @.> >

romedtino commented 5 months ago

There's really no rush to this change and I don't know what kind of planning you'd need to do on your end since there's no changes on the user side of things. This is all just in the backend for the maintainer. With that said, a prerelease can be gotten through HACS - https://github.com/romedtino/simple-wyze-vac/releases/tag/1.9.0

dwdonnelly commented 4 months ago

Jerome,

Understand. Pre-Releases (please take no offense) always make me a little nervous – and as you point out, we have time. I will be patient and wait.

Many thanks !

Dave

From: Jerome Tolentino @.> Sent: Saturday, March 23, 2024 5:45 PM To: romedtino/simple-wyze-vac @.> Cc: dwdonnelly @.>; Mention @.> Subject: Re: [romedtino/simple-wyze-vac] deprecated supported features (Issue #77)

There's really no rush to this change and I don't know what kind of planning you'd need to do on your end since there's no changes on the user side of things. This is all just in the backend for the maintainer. With that said, a prerelease can be gotten through HACS - https://github.com/romedtino/simple-wyze-vac/releases/tag/1.9.0

— Reply to this email directly, view it on GitHub https://github.com/romedtino/simple-wyze-vac/issues/77#issuecomment-2016647407 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDT7CJW2Q77GJZ5N6JMWFLYZYOZJAVCNFSM6AAAAABDLDF6KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGY2DONBQG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKDT7CPNNFJTGCTGV6NQFD3YZYOZJA5CNFSM6AAAAABDLDF6KCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTYGOMO6.gif Message ID: @. @.> >

dwdonnelly commented 4 months ago

Jerome,

New to github and it’s processes, so a couple of questions?

How do I know what version I have installed on my system? The integration does not display.

If I understand this page, https://github.com/romedtino/simple-wyze-vac, V 1.9.0 has been released – no longer in a prerelease status. Correct?

How do I update my installed version of Simple Wyze integration? This would be done by deleting the current Simply Wyse integration and then going through the documented process to install the “new version”, as stated here: https://github.com/romedtino/simple-wyze-vac?tab=readme-ov-file#installation? (there is no update button? The update process is manual: delete/remove and reinstall?)

Many thanks for your help!

Dave

From: Jerome Tolentino @.> Sent: Thursday, April 4, 2024 9:47 PM To: romedtino/simple-wyze-vac @.> Cc: dwdonnelly @.>; Mention @.> Subject: Re: [romedtino/simple-wyze-vac] deprecated supported features (Issue #77)

Closed #77 https://github.com/romedtino/simple-wyze-vac/issues/77 as completed.

— Reply to this email directly, view it on GitHub https://github.com/romedtino/simple-wyze-vac/issues/77#event-12367738683 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKDT7CKR56CXPCCZY2F267TY3YUEFAVCNFSM6AAAAABDLDF6KCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM3DONZTHA3DQMY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AKDT7CK6UJXAMRJSHM2CURTY3YUEFA5CNFSM6AAAAABDLDF6KCWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3PNVWWK3TUL5UWJTYAAAAAFYJMW45Q.gif Message ID: @. @.> >

dwdonnelly commented 4 months ago

@romedtino Just saw the update in my HA menu.....many thanks !