romelo333 / notenoughwands

This mod gives the player a number of very configurable and versatile wands
MIT License
7 stars 2 forks source link

Protection wand won't unprotect blocks. #69

Open Hunterjaguar14 opened 7 years ago

Hunterjaguar14 commented 7 years ago

Please help I don't want to have to kill more wither bosses. How do I unprotect blocks

McJty commented 7 years ago

Sneak right click on the protected blocks. Make sure you're using the same wand that was used to protect the blocks

Draxhax commented 6 years ago

I'm having the same issue. 1.12-1.5.9 in multiplayer. I have the wand in protect mode and can mark blocks as protected, but the wand doesn't do anything to the block after it has been protected if I try to use the wand on the block itself. It looks like it would, but nothing happens. I threw together a gif showing it. I'm running Minecraft 1.12.2, Forge 14.23.0.2531, in the mod pack All The Mods 3 (v5.1).

Unprotect Example

I first swapped the wand to protect mode and protected a block. I swapped it to unprotect and attempted to unprotect the block while not sneaking and while sneaking. Lastly, I swapped to the clear all function and showed that it still won't work when I interact with the protected block, but I can clear all when interacting on a block that isn't protected.

Based on my testing, the onPlayerInteractEvent in the current build simply cancels all events that involve interacting with a block that is protected instead of doing any kind of check to whether it's the wand that protected it. I can't place a block on top of it, I have the Akashik Tome and it doesn't open the wiki when I sneak right-click on it, so as far as I can tell, if it can cancel the event, it will.

Hope this helps!

dav9670 commented 6 years ago

Bumping, having this problem in ATM 3, protection wand, normal and master version wont unprotect the blocks, in fact nothing happens at all when right clicking a protected block. Clearing all protected blocks works with blocks set with a master wand, but blocks set with another wand wont clear.

Edit: Went into the config and set the option to protect from interaction with the block to false, which permitted me to interact with the block using the master wand and unprotected it. Still, with that option set to true, it was impossible to unprotect the block.

EmilyV99 commented 6 years ago

interactionProtection=true prevents ALL interaction with blocks, including unprotecting them. Suggestion: Make it so when interactionProtection=true, ALL interaction is prevented unless:

  1. The player interacting is the one who protected it (should always be able to interact with own protections)
  2. The player interacting with it is an OP using a Master Protection Wand (should be able to disable any protection)