search

romelo333 / notenoughwands

This mod gives the player a number of very configurable and versatile wands
MIT License
7 stars 2 forks source link

[1.12.2] Swapping Wand w/ Draconic Evolution Causes Issues #71

Closed SnowShock35 closed 6 years ago

SnowShock35 commented 6 years ago

Issue Details

Issue Description

When using the swapping wand on end or nether Draconium Ore it returns the overworld variant for some odd reason. I've tried to figure out why but don't see how or why it would occur. all three variants have separate metadata so should be able to distinguish between them

McJty commented 6 years ago

I'll check it out later

SnowShock35 commented 6 years ago

ty :heart:

McJty commented 6 years ago

This could be a bug in Draconic Evolution itself. If I do this:

    ItemStack item = block.getItem(world, pos, state);

Where the block points to a nether variant of draconium ore I still get an itemstack that indicates normal Draconium ore. Block.getItem() uses Item.getItemFromBlock(this) and Block.damageDropped(state). Perhaps submitting a link to this issue on Draconic Evolution's github and then we can see how we can work this out

brandon3055 commented 6 years ago

Found the problem. Your calling block.getItem when according to this you should be calling getPickBlock I only override getPickBlock but i will add an override for getItem to fix issues like this.

McJty commented 6 years ago

Ok. I can call getPickBlock too. I just hope that no mod depends on the the RayTraceResult being non null because I can't supply that parameter