search

romeovs / react-a11y

Identifies accessibility issues in your React.js elements
MIT License
19 stars 5 forks source link

Can't be used with npm #1

Closed gf3 closed 7 years ago

gf3 commented 8 years ago

When trying to install your package the required main entry can't be found and the src dir is ignored. Here's what the installed package looks like:

node_modules/react-a11y/
├── docs/
├── test/
├── .babelrc
├── .eslintrc
├── .jshintignore
├── .jshintrc
├── .npmignore
├── .travis.yml
├── CHANGELOG.md
├── LICENSE
├── README.md
├── mkdocs.js
└── package.json
romeovs commented 8 years ago

Can you post the output of npm install romeovs/reac-a11y? I always forget how to do git hosted npm packages right without breaking the npm hosted package that it represents.

I'll look in to it soon! In the meantime, pull requests are welcome!

gf3 commented 8 years ago

the install works fine, but since it's not being built and published the lib dir is not included (.gitignore) and the src dir is not included by npm (.npmignore)

romeovs commented 8 years ago

Can you try again please?

I just got a new internship at a cool company so most of my time is going there, but I want to keep this project alive!!

erin-doyle commented 7 years ago

This is still a problem. The /lib directory is not being included in the package and so it throws an error when the library is included or required:

Module not found: Error: Can't resolve 'react-a11y-alt/lib/index.js'

erin-doyle commented 7 years ago

I think this issue will be fixed if we can just get a new version published @romeovs ?

romeovs commented 7 years ago

Done! Also, I'd be more than willing to transfer the nom package to someone that is more involved with the project.

erin-doyle commented 7 years ago

This is working for me now, thanks! I think this issue can be closed.

erin-doyle commented 7 years ago

And I sent you an email on transferring the npm package @romeovs. 👍