search

romesco / hydra-lightning

Configuration classes enabling Hydra to configure and manage Pytorch Lightning projects.
MIT License
40 stars 7 forks source link

Support for loggers #12

Open piraka9011 opened 3 years ago

piraka9011 commented 3 years ago

It looks like there's no direct support for Loggers (or other nested structures) used by the Trainer. Is there any plan to suppport that? Is it as simple as running config generation script?

romesco commented 3 years ago

Hey @piraka9011, that's a great idea!

I've been working on hydra-torch and configen to try to get things finished for supporting the nested structures you're referring to (especially in the context of instantiating datasets/dataloaders/transforms).

I could definitely use some help adding useful configs to this repo in the meantime!

Could you get a PR draft going? With the state configen is in, it should get us pretty close, but there might be a couple tweaks necessary.

I wrote out some steps on how to use configen here: https://github.com/pytorch/hydra-torch/blob/dev/overview/CONTRIBUTING.md#using-configen

romesco commented 3 years ago

Also, if needbe, feel free to ping me on the hydra chat: https://hydra-framework.zulipchat.com/#narrow/stream/257092-Hydra-Torch/topic/General @ rosario

piraka9011 commented 3 years ago

FYI, I came across this issue when attempting to regenerate the configs: https://github.com/facebookresearch/hydra/issues/1299