search

romesco / hydra-lightning

Configuration classes enabling Hydra to configure and manage Pytorch Lightning projects.
MIT License
40 stars 7 forks source link

Add loggers #14

Closed piraka9011 closed 3 years ago

piraka9011 commented 3 years ago

Draft PR for loggers, however, this does not work out of box since I had to make two changes

It seems like there needs to be an upstream fix for configen.

The Pytorch Trainer logger config is also not updated accordingly.

romesco commented 3 years ago

Awesome! Thanks for pushing into unknown territory with this one. It's also great feedback for improving robustness on configen. I think we can make the appropriate upstream configen modifications pretty quickly.

Did you write any simple instantiation tests for the loggers?

romesco commented 3 years ago

@piraka9011 I've updated the info in CONTRIBUTING.md on setting up a dev environment.

CI should now be completely working if you want to use it as a gating function to check your tests! Hope this helps! =]

piraka9011 commented 3 years ago

The workflow I used to get setup is similar but good to have this documented, thanks! I will take a look at this (and configen) during the weekend.