search

romesco / hydra-lightning

Configuration classes enabling Hydra to configure and manage Pytorch Lightning projects.
MIT License
40 stars 7 forks source link

ModelCheckpointConf wrong default value #16

Open NikolaiBabkin opened 3 years ago

NikolaiBabkin commented 3 years ago

In _hydra_configs/pytorchlightning/callbacks.py in ModelCheckpointConf there is no default value for feeld dirpath. Should be: dirpath: Any = None according to https://pytorch-lightning.readthedocs.io/en/latest/generated/pytorch_lightning.callbacks.ModelCheckpoint.html

romesco commented 3 years ago

Thank you @NikolaiBabkin, I'll look into addressing this upstream in configen, as well!

reuben commented 3 years ago

Was this fixed? PR #17 was merged but this issue is still open.