rometools / rome

Java library for RSS and Atom feeds
https://rometools.github.io/rome
Apache License 2.0
912 stars 168 forks source link

Unable to parse OPML 1.1 #660

Open lostsidewalk opened 1 year ago

lostsidewalk commented 1 year ago

Hi, I have a few OPML documents exported from various RSS readers that have a version attribute value of "1.1". It looks like ROME OPML presently only supports OMPL versions 1.0 and 2.0. Attempting to parse an OPML document of any other version results in an invalid document error because no parser can be located.

This page describes the history of OPML 1.1: http://opml.org/history/aboutOpml11.opml.

It appears that a single element called 'cloud' was added to OPML to mirror a similar addition to RSS 0.92.

Interestingly, the linked OPML 1.1 announcement states: "if you're wondering what to do -- if you see an OPML 1.1 file, you should treat it like an OPML 1.0 file. That's it."

If ROME OPML doesn't care about this particular element, it might be a good idea to just change the `isMyType' condition in OMPL10Parser to accommodate this new version. Alternately, adding proper support for it wouldn't be that much of a change either. Regardless, raising this issue because I'm seeing a decent number of these documents submitted by users, and I think a minor change to add support for parsing these would be a useful addition to this project.

PatrickGotthard commented 1 year ago

Hi @lostsidewalk,

I will have a look at the OPML 1.1 support from @antoniosanct after we've finished the new documentation. Unfortunately this will take some time, I'm very busy at the moment.

Regards, Patrick

allentown521 commented 4 months ago

It's been a long time, I think the admin should merge the code