search

romgrk / barbar.nvim

The neovim tabline plugin.
2.3k stars 85 forks source link

fix(doc): use `buffer_number` instead of `buffer_numbers` to avoid inconsistency #325

Closed younger-1 closed 1 year ago

younger-1 commented 2 years ago

README.md use buffer_number, but the code use buffer_numbers.

Iron-E commented 2 years ago

@romgrk This has been present since v1.0.0; I'm not sure whether to change the docs or change the code here. Changing the code might break people's configs, but it also might make them work. I'll let you decide

romgrk commented 2 years ago

I like the change but I don't like breaking stuff. Can we get both? Can we add a legacy check for the old value? Can we warn once if the user is using the old value?

younger-1 commented 2 years ago

@romgrk cc

Iron-E commented 1 year ago

@younger-1 sorry about the delay. There have been quite a few changes upstream that make resolving the diff conflicts difficult— namely, that the checks for the conditions in question are in a totally different file now.

If you're still open to working on this, you should re-branch off of master and make the changes in the options.lua file. There's less of a chance of any bugs as a result of the changes, so hopefully that can be seen as a silver lining :crossed_fingers:

Iron-E commented 1 year ago

If you decide to start working on this again, let me know, and we can reopen this.

Iron-E commented 1 year ago

This PR was superseded by #386.