romgrk / barbar.nvim

The neovim tabline plugin.
2.23k stars 83 forks source link

Wrong background colors for tabs with LSP alerts #351

Closed simplepad closed 1 year ago

simplepad commented 1 year ago

Description

Barbar uses wrong background color for the LSP alerts part of tabs, both active and inactive (inactive are harder to spot but the color is wrong too).

To Reproduce

  1. Have neovim with LSP, barbar and tokyonight theme plugins installed.
  2. Try to edit a file that has LSP alerts.

Screenshots image

Informations Neovim version: v0.9.0-dev-594+gc590641fe

FahimAnayet commented 1 year ago

I experienced the same problem with the Nord color scheme.

Iron-E commented 1 year ago

@simplepad @FahimAnayet this issue is caused because the colorschemes that were mentioned only define some of the highlight groups for barbar, which means the rest are defaults (which don't look quite right WRT how the rest of the colorscheme looks).

Here is where tokyonight defines the colors for barbar. The missing ones are:

It also defines one group which does not exist: BufferTabpage.

The most important groups of those are the ERROR, HINT, INFO, and WARN groups, as well as the BufferAlternate groups.

I would make an issue on those colorschemes' respective repositories and ask for these groups to be added.

Iron-E commented 1 year ago

Closing since we can't fix on our side, though I am happy to answer any other related questions :)

simplepad commented 1 year ago

Wow, thank you for your explanation! I will open an issue in the theme's repo.