romgrk / barbar.nvim

The neovim tabline plugin.
2.2k stars 81 forks source link

Multiple deprecation warnings on startup #406

Closed eggbean closed 1 year ago

eggbean commented 1 year ago
$ nvim --version
NVIM v0.8.2
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: /usr/bin/gcc-10 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DNVIM_TS_HAS_SET_MATCH_LIMIT -DNVIM_TS_HAS_SET_ALLOCATOR -O2 -g -Og -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wdouble-promotion -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fno-common -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -DMIN_LOG_LEVEL=3 -I/__w/neovim/neovim/build/cmake.config -I/__w/neovim/neovim/src -I/__w/neovim/neovim/.deps/usr/include -I/usr/include -I/__w/neovim/neovim/build/src/nvim/auto -I/__w/neovim/neovim/build/include
Compiled by root@4ae72dcad031

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/__w/neovim/neovim/build/nvim.AppDir/usr/share/nvim"

I get a lot of deprecation warnings on startup:

http://sprunge.us/KJh1c1

Iron-E commented 1 year ago

To stop getting the deprecation warnings, you can transition away from the deprecated options. This is kind of an extreme case, because it seems you're using most (if not all) of the deprecated options. The warnings themselves tell you what options we're moving to

Iron-E commented 1 year ago

If you have any questions about your equivalents for your specific setup btw, don't hesitate to let us know. Feel free to reopen in that case.

romgrk commented 1 year ago

I must say I don't like too much breaking & annoying users as much as we do. It would be neat to find a way to show the deprecation warnings once per commit (e.g. if we've already notified at this commit, don't do it again). Or maybe once every few days would be better?

Iron-E commented 1 year ago

I must say I don't like too much breaking & annoying users as much as we do. It would be neat to find a way to show the deprecation warnings once per commit (e.g. if we've already notified at this commit, don't do it again). Or maybe once every few days would be better?

We could store something in the /tmp directory, so that it's once on boot? That could be the simplest solution

romgrk commented 1 year ago

Some users rarely reboot. My goal is to find a balance between being annoying and getting our users to migrate before we break their configs. I think with the new saved state code for recently closed buffers, we could throw in a last_notification: '2023-04-01' field, and show a notification every few days. Let's say four days.

Iron-E commented 1 year ago

Didn't think about desktop users— you're right on that one. Sounds good.