romgrk / barbar.nvim

The neovim tabline plugin.
2.17k stars 82 forks source link

ref: `local m` → `local groups` #446

Closed Iron-E closed 1 year ago

Iron-E commented 1 year ago

This PR has a few advantages:

  1. Uses the naming scheme seen in other modules
    • i.e. local mlocal groups
  2. Creates a clear naming difference between group_clumps and group: old name new name
    barbar.render.group barbar.groups.item
    barbar.render.group[] barbar.groups
    barbar.render.group_clump barbar.render.group
  3. Alleviates cyclical resolution of @params in the groups module
    • e.g. almost all of the params were barbar.render.group[], but barbar.render actually depends on barbar.groups, so it would be cyclical in a traditional type checking system
  4. Performance increase by using for i = x, y, -1 instead of utils.list_reverse
Iron-E commented 1 year ago

Ok, I've revised the PR based on your feedback. Summary: