default close icon is broken with v3.0.0 of nerd icons

romgrk / barbar.nvim

The neovim tabline plugin.

2.26k stars 85 forks source link

default close icon is broken with v3.0.0 of nerd icons #521

Closed bluskript closed 1 year ago

bluskript commented 1 year ago

Description

Here, the default close icon is specified to be "". With release v3.0.0 of nerd fonts, all of the material design icons were moved to different codepoints, "󰅖" works. Considering most users will be updating to v3.0.0, it would be good to change the default.

To Reproduce

Install barbar and nerd fonts 3.0.0 or above. Observe close icon is broken.

Screenshots

Informations Neovim version: 0.9.1

Iron-E commented 1 year ago

We already fixed this issue in de37647f05a5b556b6426b78c4608bbd40a8089f, just seems that the documentation is stale. However it does seem that there are diagnostic icons are missing, I'll open a PR to fix both issues.

Iron-E commented 1 year ago

I've opened #523, does that help?

bluskript commented 1 year ago

Yeah that branch works! Thank you!