search

romgrk / barbar.nvim

The neovim tabline plugin.
2.16k stars 81 forks source link

refactor: requires on 'bufferline' redirect to 'barbar' #536

Closed JosefLitos closed 7 months ago

JosefLitos commented 7 months ago

Closes #535

Note: I only added remapping for the top directory, because the ui and utils directory weren't copied before either. It is a simple fix to do it for actually all files, though. So feel free to tell me to do so.

Iron-E commented 7 months ago

I'll test this later, thank you for the work!

The utils and render modules have differing layouts to the barbar counterparts; skimming the implementation I don't see them explicitly handled. Was that taken care of?

JosefLitos commented 7 months ago

The utils and render modules have differing layouts to the barbar counterparts

Oh, I didn't know that. I will look into it.

Iron-E commented 7 months ago

Just to note, the bufferline/utils.lua and bufferline/render.lua files take backwards compatibility into account, so that behavior can probably be copied over (in case my previous comment made it seem otherwise)

romgrk commented 7 months ago

I think I disagree with this change. Reasons:

JosefLitos commented 7 months ago

I may try to find a way just out of curiosity but I understand v2.0 will make this PR redundant.

Iron-E commented 7 months ago

It's not like we're copying the full plugin source, we just add some redirects

Although that's true, this does deduplicate that process (which was my reasoning behind accepting a pursuit in this direction).

The logic might look fine, but there is always the risk of breaking users' config. I'd rather have one explicit breaking version rather than risk it here. In particular because I don't see any gain to removing those 1-line files.

Yeah… the current solution does work; if I could go back I'd probably do it this way but that doesn't necessarily mean it has to change now.

@JosefLitos thank you for teaching me something about Lua!