fix(550): buffer close references

romgrk / barbar.nvim

The neovim tabline plugin.

2.16k stars 81 forks source link

fix(550): buffer close references #565

Closed Iron-E closed 3 months ago

Iron-E commented 3 months ago

There were a couple edge cases I discovered with the previous PR (#563), namely:

Not all "buffer reference literals" were detected. Race conditions also occurred when doing, e.g. :BufferDelete $
Older devices may finish events in different orders. This implementation is deterministic.

romgrk commented 2 months ago

I'm seeing some issues with buffer closing, sometimes when I run :BufferClose it has no effect. I'm not sure which of this PR or #563 is causing it, any idea?

I don't like how complex the bdelete code has become.

romgrk commented 2 months ago

It looks like it's #563, bbye.closing was left at 1 so I couldn't close any more buffers.