search

romgrk / doom-one.vim

A dark colorschme for vim, ported from doom-emacs' doom-one theme.
104 stars 19 forks source link

White tilde... #8

Closed ahmedkhalf closed 3 years ago

ahmedkhalf commented 3 years ago

image I don't like the white tilde, can you please change the color to the gray used for inactive line number. If no, then could you please give me an indication as to how I can do this myself. Thanks in advance.

ahmedkhalf commented 3 years ago

I just noticed that in your screenshot there are no tildes, could you please tell me how you did that?

ahmedkhalf commented 3 years ago

I tried hiding the tildes using highlight! EndOfBuffer ctermbg=bg ctermfg=bg guibg=bg guifg=bg but I get: E420: BG color unknown. I also tried setting them to none, but they don't give any result/feedback, so it doesn't seem it affect anything.

ahmedkhalf commented 3 years ago

Okay fixed it, I had to remove the exclamation sign after highlight: highlight EndOfBuffer guifg=bg. It would be great if this is added as the default behavior though @romgrk

romgrk commented 3 years ago

Sorry for the delay.

That's weird it's defined here: https://github.com/romgrk/doom-one.vim/blob/master/colors/doom-one.vim#L120 Not sure why it's not working but running verbose hi EndOfBuffer would give me more info.

ahmedkhalf commented 3 years ago

@romgrk 

:verbose hi EndOfBuffer
EndOfBuffer    xxx guifg=#bbc2cf guibg=#282c34
        Last set from ~/.config/nvim/plugged/doom-one.vim/colors/doom-one.vim line 42

I use neovim nightly.

ahmedkhalf commented 3 years ago

Maybe the line should be changed from: call s:_('EndOfBuffer', s:fg, s:bg) to call s:_('EndOfBuffer', s:bg, s:bg)?

romgrk commented 3 years ago

Sure, done.