search

romgrk / fzy-lua-native

Luajit FFI bindings to FZY
118 stars 16 forks source link

Support x64 and arm64 on darwin. #8

Closed hungrybirder closed 3 years ago

hungrybirder commented 3 years ago

Hi, On my m1 Mac mini , the arch name is arm64, not aarch64. And I also test it on 2019 MacBook Pro(x86_64). It works well for both arch.

Please check it out.

Thank you.

romgrk commented 3 years ago

Mmm, so you mean for your machine uname -m returns arm64? And what is the output of luajit -e 'print(jit.arch)'?

Both names refer to the same thing so it doesn't matter which one we choose, the idea is to have them all map to a common string. And in general it's easier to manipulate strings in lua than in bash so I'd rather to the translation there and not in the Makefile.

hungrybirder commented 3 years ago

Mmm, so you mean for your machine uname -m returns arm64? And what is the output of luajit -e 'print(jit.arch)'?

Both names refer to the same thing so it doesn't matter which one we choose, the idea is to have them all map to a common string. And in general it's easier to manipulate strings in lua than in bash so I'd rather to the translation there and not in the Makefile.

On my Mac mini uname -m output is arm64 luajit -e 'print(jit.arch)' output is arm64

FYI.

romgrk commented 3 years ago

Got it. I've fixed this in dc4ed9e728bc7a79ab86494e01688848d7160ef8 because I need to tune the GHA anyway, they've been failing for some commits.

Thanks.