fix(value): say that we can convert number to g(u)int64

romgrk / node-gtk

GTK+ bindings for NodeJS (via GObject introspection)

MIT License

494 stars 41 forks source link

fix(value): say that we can convert number to g(u)int64 #301

Closed peat-psuwit closed 3 years ago

peat-psuwit commented 3 years ago

We already has support for it in V8ToGValue() and vice versa, so it's a bug that CanConvertV8ToGValue() says that we cannot.

romgrk commented 3 years ago

Thanks, sorry for the delay.

TeaSeaLancs commented 3 years ago

Hi, will there be a versioned release with this fix in soon? It's a fairly critical blocker to adoption of version 0.9.0.

romgrk commented 2 years ago

@TeaSeaLancs I've published a minor release just now from master. Give it an hour or two to finish building pre-built binaries and it should be usabled. Let me know if there is any issue.