search

romgrk / node-gtk

GTK+ bindings for NodeJS (via GObject introspection)
MIT License
494 stars 41 forks source link

WebKit2.WebView 'load-failed' crash #306

Closed rogeriojlle closed 3 years ago

rogeriojlle commented 3 years ago

I'm trying to catch the 'load-failed' event from a WebKit2.WebView(). But the script ends with the error:

this.webView.on('load-failed', (e) => {
      console.log({ e });
});
[INFO] loop.cc: QuitLoopStack: 168: calling (anonymous)
W20210725-07:37:53.409(-3)? (STDERR) /dev/shm/teste/.meteor/local/isopacks/desktop-gtk/npm/node_modules/node-gtk/lib/overrides/Gtk-3.0.js:37
W20210725-07:37:53.410(-3)? (STDERR)         originalMain()
W20210725-07:37:53.410(-3)? (STDERR)         ^
W20210725-07:37:53.410(-3)? (STDERR) 
W20210725-07:37:53.410(-3)? (STDERR) TypeError: Cannot convert value "undefined" to type gboolean in signal "load-failed"
W20210725-07:37:53.411(-3)? (STDERR)     at Object.main (/dev/shm/teste/.meteor/local/isopacks/desktop-gtk/npm/node_modules/node-gtk/lib/overrides/Gtk-3.0.js:37:9)
rogeriojlle commented 3 years ago

found the error: I forgot to return a boolean 🧐 https://lazka.github.io/pgi-docs/WebKit2-4.0/classes/WebView.html#WebKit2.WebView.signals.load_failed