Fix macOS builds - Githubissues

romgrk / node-gtk

GTK+ bindings for NodeJS (via GObject introspection)

MIT License

493 stars 41 forks source link

Fix macOS builds #325

Closed lleyton closed 2 years ago

lleyton commented 2 years ago

Currently, the gi.cc file imports the girepository.h in a way that is inconsistent with the rest of the codebase, prefixed with a gobject-introspection-1.0/. This has also been breaking builds on my M1 Mac running Catalina, when installing node-gtk on Node 18. I've tested builds on both Fedora and macOS, and it seems to work perfectly.

romgrk commented 2 years ago

Ok. Test suite if failing for macOS but it seems unrelated and the build itself succeeds, so I'll merge anyway. Thanks :)