search

romgrk / node-gtk

GTK+ bindings for NodeJS (via GObject introspection)
MIT License
493 stars 41 forks source link

Return back interval timer #329

Closed ten0s closed 2 years ago

ten0s commented 2 years ago

Return back code introduced in https://github.com/romgrk/node-gtk/commit/4ffe627ccb9fdf08743883ce5271c5be24597c3d and the most probably lost during refactoring done in https://github.com/romgrk/node-gtk/commit/c64ff5b2c355636d985ee23e345bbb7a5d05b53f and considering that the code below is still there

if (Gtk.mainLevel() === 0) {
          placeholderIntervalID = clearInterval(placeholderIntervalID)
        }

Unfortunately, I don't have a simple example, but this change does fix some UI freezes.

romgrk commented 2 years ago

Alright, let's put it back.