search

romgrk / node-gtk

GTK+ bindings for NodeJS (via GObject introspection)
MIT License
493 stars 41 forks source link

Fix tests #336

Closed ten0s closed 1 year ago

ten0s commented 1 year ago
ten0s commented 1 year ago

Fixes #326

romgrk commented 1 year ago

Do you wanna debug the error test? Otherwise I'm fine if we just skip it on windows, I don't have much resources to invest in this project but I'd rather have it working with inaccuracies than not working at all. We can open an issue to track the bug.

ten0s commented 1 year ago

I disabled a couple of tests on Mac and Windows. Windows passed. Mac sometimes fails during setup phase. See https://github.com/ten0s/node-gtk/actions/runs/5297965131/jobs/9590225913

romgrk commented 1 year ago

Alright, so this can be merged? The changes LGTM.

Any idea why macOS is flaky during setup?

ten0s commented 1 year ago

It can be merged.

Regarding Mac, similar issue was in Homebrew half year ago, was fixed after a while

romgrk commented 1 year ago

Got it. Thanks for the PR!