Closed romgrk closed 1 year ago
@ten0s Do you remember why that line was necessary? It seems to break vfuncs out arguments:
https://github.com/romgrk/node-gtk/blob/79b6ef4469b6eea770e273574193d40a54bce5a5/src/value.cc#L880
@romgrk, it was needed for V8ToGIArgument to make it work on Windows, maybe it's not needed for V8ToOutGIArgument, I never faced such an issue.
BTW, I created https://github.com/romgrk/node-gtk/pull/336 some time ago, not sure why it got closed.
I also update actions and readme, take a look at https://github.com/ten0s/node-gtk
Neat, didn't saw, haven't been around much. Do you wanna re-open that PR? Is it ready to be merged?
error.js failed on Windows. Not sure why. It worked back then
Adapt for node 18 & 20 changes.