romgrk / node-todoist

nodejs implementation of todoist sync API
21 stars 12 forks source link

Fix due date type when creating a new item #22

Closed riexn closed 3 years ago

riexn commented 3 years ago

fixed

item.add()'s due property had the incorrect type for it. Based on the documentation, it should be either:

"due": {"string":  "tomorrow at 12"}
"due": {"string": "tomorrow at 12", "timezone": "Asia/Jakarta"} // timezone doesn't seem to work anymore, since they mentioned it will always be null
"due": {"date": "2018-10-14"}

added

changed

lordnox commented 3 years ago

Thank you 🙏!

I might have missed this when implementing the types in the first place. I'll take a look later

romgrk commented 3 years ago

@lordnox let us know if anything needs to be changed, but I'll merge as it looks fine to me.